Conversation
7740b19 to
1e907d9
Compare
Spartan322
reviewed
Feb 23, 2026
Spartan322
reviewed
Feb 23, 2026
Spartan322
reviewed
Feb 23, 2026
Spartan322
reviewed
Feb 23, 2026
Spartan322
reviewed
Feb 23, 2026
Spartan322
reviewed
Feb 23, 2026
Spartan322
reviewed
Feb 23, 2026
1e907d9 to
6c44fcb
Compare
6c44fcb to
27edadb
Compare
Spartan322
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T*is used throughout our codebase to store pointers to objects wheneverT&isn't viable due to move semantics.For example
vector_ordered_set<Mod const*>. Technically these pointers could be null and to be safe you'd have to check it isn't null before dereferencing.Often we know the pointer may never be null.
std::reference_wrapper<T>is a great way to communicate that. It is implicitly convertible toT&. This allows us to dofor (Mod const& mod : loaded_mods)(withmemory::vector<std::reference_wrapper<const Mod>> loaded_mods).This approach does require the type is hashable and equatable. For types derived from HasIndex, the index is used for this. For types that don't derive from HasIndex, but do derive from HasIdentifier, the identifier is used.