Merged
Conversation
Mionsz
force-pushed
the
private/mlinkiew/scripts-optimizing-and-minimizing
branch
from
3030540 to
bfaee76
Compare
Mionsz
added
bug fix
REFACTOR: Unification of build scripts, update setup_ice_irdma.sh Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
FIX: Update irdm install script and move it to separate method. Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Refactor: Minor update setup_ice_irdma.sh Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Mionsz
force-pushed
the
private/mlinkiew/scripts-optimizing-and-minimizing
branch
from
bfaee76 to
069a94b
Compare
Collaborator
|
@Mionsz could you check if it's still up to date, update and resolve conflict so we can merge or dismiss? |
…mizing Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Collaborator
Author
Done now. |
ko80
reviewed
Apr 15, 2025
ko80
reviewed
Apr 15, 2025
ko80
reviewed
Apr 15, 2025
Co-authored-by: Konstantin Ilichev <konstantin.ilichev@intel.com> Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Co-authored-by: Konstantin Ilichev <konstantin.ilichev@intel.com> Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Update setup_ice_irdma.sh and fix naming convention regarding irdma and rdma --> now all lowercase Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
MateuszGrabuszynski
approved these changes
Apr 15, 2025
Collaborator
MateuszGrabuszynski
left a comment
MateuszGrabuszynski
left a comment
There was a problem hiding this comment.
Code looks good. 👍🏻
ko80
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: Scripting fixes and simplification. Addressing the issue created by user:
#344
REFACTOR: One distinct entry point script for drivers and OS level configuration instead of separate ones.