Add multicast source filter IP address in ST 2110 connections#384
Merged
ko80 merged 2 commits intoOpenVisualCloud:mainfrom Apr 14, 2025
Merged
Add multicast source filter IP address in ST 2110 connections#384ko80 merged 2 commits intoOpenVisualCloud:mainfrom
ko80 merged 2 commits intoOpenVisualCloud:mainfrom
Conversation
* Add JSON field "multicastSourceIpAddr". * Add FFmpeg argument "-mcast_sip_addr". * Rename JSON ST 2110 connection parameters "remoteIpAddr" and "remotePort" to "ipAddr" and "port" respectively to better align with MTL API. * Adjust unit tests. * Update documentation. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
ko80
requested review from
KarolinaPomian,
MateuszGrabuszynski,
Mionsz,
andremiszcz,
staszczuk,
tszumski and
zLukas
and removed request for
soopel
tszumski
previously approved these changes
Apr 14, 2025
Mionsz
previously approved these changes
Apr 14, 2025
MateuszGrabuszynski
previously approved these changes
Apr 14, 2025
Collaborator
MateuszGrabuszynski
left a comment
MateuszGrabuszynski
left a comment
There was a problem hiding this comment.
I do not see any issues looking at the code. :)
zLukas
previously approved these changes
Apr 14, 2025
Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
ko80
dismissed stale reviews from zLukas, MateuszGrabuszynski, Mionsz, and tszumski
via
6b262ea
ko80
force-pushed
the
add-mcast-sip-addr
branch
from
9ac715e to
6b262ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.