Remove old and unused code#391
Merged
tszumski merged 4 commits intoOpenVisualCloud:mainfrom May 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a large amount of legacy and unused code from the media-proxy project to simplify the codebase.
- Removed outdated test files, session implementations for RDMA and MTL, and associated header files.
- Eliminated the legacy API server (TCP) code and proxy context functionality no longer in use.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| media-proxy/tests/proxy_context_tests.cc | Removed unused test cases for ProxyContext. |
| media-proxy/src/shm_memif_common.c | Removed obsolete shared memory interface functions for memif. |
| media-proxy/src/session-rdma-tx.cc | Removed legacy RDMA TX session implementation. |
| media-proxy/src/session-rdma-rx.cc | Removed legacy RDMA RX session implementation. |
| media-proxy/src/session-mtl.cc | Removed legacy MTL session implementation. |
| media-proxy/src/session-mtl-st2110-30-tx.cc | Removed legacy ST2110-30 TX session for MTL. |
| media-proxy/src/session-mtl-st2110-30-rx.cc | Removed legacy ST2110-30 RX session for MTL. |
| media-proxy/src/session-mtl-st2110-22-tx.cc | Removed legacy ST2110-22 TX session for MTL. |
| media-proxy/src/session-mtl-st2110-22 rx.cc | Removed legacy ST2110-22 RX session for MTL. |
| media-proxy/src/session-mtl-st2110-20-tx.cc | Removed legacy ST2110-20 TX session for MTL. |
| media-proxy/src/session-mtl-st2110-20-rx.cc | Removed legacy ST2110-20 RX session for MTL. |
| media-proxy/src/session-base.cc | Removed base session code no longer used by active sessions. |
| media-proxy/src/proxy_context.cc | Removed full implementation of ProxyContext. |
| media-proxy/src/media_proxy.cc | Cleaned up main function by removing initialization of unused legacy components. |
| media-proxy/src/api_server_tcp.cc | Removed legacy TCP API server code. |
| media-proxy/include/session-rdma.h | Removed header for obsolete RDMA session API. |
| media-proxy/include/session-mtl.h | Removed header for obsolete MTL session API. |
| media-proxy/include/session-base.h | Removed header for base session class no longer referenced. |
| media-proxy/include/proxy_context.h | Removed header for obsolete ProxyContext functionality. |
| media-proxy/include/api_server_tcp.h | Removed header for legacy TCP API server. |
Collaborator
MateuszGrabuszynski
left a comment
MateuszGrabuszynski
left a comment
There was a problem hiding this comment.
There are 2 references that bother me a bit (as commented).
tszumski
force-pushed
the
tszumski-cleanup-deprecated-code
branch
from
35a95f6 to
a10f88f
Compare
Hard exiting with exit() is no longer needed after legacy TCP API support is removed. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
Remove hard exiting in Media Proxy
ko80
approved these changes
May 29, 2025
Collaborator
ko80
left a comment
ko80
left a comment
There was a problem hiding this comment.
Checked in my environment with FFmpeg and two Media Proxies.
Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove old and unused code