Skip to content

Comments

Update setup_ice_irdma.sh#394

Merged
Mionsz merged 10 commits intomainfrom
Mionsz-patch-1
Jun 6, 2025
Merged

Update setup_ice_irdma.sh#394
Mionsz merged 10 commits intomainfrom
Mionsz-patch-1

Conversation

@Mionsz
Copy link
Collaborator

@Mionsz Mionsz commented May 21, 2025

Fix issues with scripts.

@Mionsz Mionsz requested review from moleksy and soopel as code owners May 21, 2025 10:39
@Mionsz Mionsz added bug fix Something isn't working enhancement New feature or request maintainers review request Pull request is ready to be reviewed. labels May 27, 2025
@staszczuk
Copy link
Collaborator

The scripts are fine. Tested on a freshly installed Ubuntu 22.04 Server.

@Mionsz Mionsz enabled auto-merge (squash) May 27, 2025 11:00
@ko80 ko80 requested review from tszumski and removed request for soopel May 27, 2025 11:00
Copy link
Collaborator

@ko80 ko80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mionsz Could you update the documentation? There is some misalignment: no such script in the repo
image

@ko80 ko80 requested a review from andremiszcz May 27, 2025 11:05
@ko80 ko80 disabled auto-merge May 27, 2025 11:25
@ko80 ko80 requested a review from staszczuk May 27, 2025 16:56
moleksy
moleksy previously approved these changes May 28, 2025
Copy link
Collaborator

@moleksy moleksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@staszczuk staszczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested after the changes on a fresh Ubuntu 22.04 Server.

Copy link
Collaborator

@andremiszcz andremiszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MateuszGrabuszynski
Copy link
Collaborator

Resolves #344.

Mionsz and others added 6 commits June 6, 2025 20:23
Fix issues with scripts.

Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Update setup_ice_irdma.sh to fix installation issues.
Add missing download driver for ice
Add missing include for install of libfabrics

Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
ADD: Update common.sh to include MTL versions and load it.


Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
FIX: Common.sh to not throw error on MTL values.env missing

Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Mionsz and others added 4 commits June 6, 2025 20:23
Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Signed-off-by: Miłosz Linkiewicz <milosz.linkiewicz@intel.com>
Signed-off-by: Paweł Staszczuk <41273017+staszczuk@users.noreply.github.com>
@Mionsz Mionsz enabled auto-merge (squash) June 6, 2025 18:24
@Mionsz Mionsz merged commit c61e9c9 into main Jun 6, 2025
9 checks passed
@Mionsz Mionsz deleted the Mionsz-patch-1 branch June 6, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Something isn't working enhancement New feature or request maintainers review request Pull request is ready to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants