Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes RDMA RX bridge creation by addressing a memory leak in error handling and updates the libfabric library version.
- Fixed memory leak in RDMA RX bridge creation error handling
- Updated libfabric version from v1.22.0 to v2.0.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| versions.env | Updates libfabric version to v2.0.0 |
| media-proxy/src/mesh/manager_bridges.cc | Adds missing memory cleanup in RDMA RX bridge creation error path |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ko80
approved these changes
Sep 10, 2025
ko80
force-pushed
the
RDMA-MCM-fix
branch
3 times, most recently
from
9ba1aef to
bf13210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RDMA RX bridge creation