Remove clang-format #420
Merged
Remove clang-format #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not enforce clang-format since the code style differs. Enforcing clang-format requires huge refactoring in the code base. Instead, use clang-format locally, per source file. Signed-off-by: Konstantin Ilichev <[email protected]>
ko80
requested review from
Copilot
and removed request for
moleksy and
soopel
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes clang-format validation from the GitHub Actions linter workflow to avoid enforcing a code style that differs from the existing codebase, allowing clang-format to be used locally instead.
- Removes the
VALIDATE_CLANG_FORMAT: falseconfiguration line from the linter workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not enforce clang-format since the code style differs. Enforcing clang-format requires huge refactoring in the code base.
Instead, use clang-format locally, per source file.