Skip to content

Fix: add mutex protection in mcast_membership_report_on_query to prevent data race condition #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: add mutex protection in mcast_membership_report_on_query to prevent data race condition #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/src/mt_mcast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,17 @@ int mcast_membership_general_query(struct mtl_main_impl* impl, enum mtl_port por
static int mcast_membership_report_on_query(struct mtl_main_impl* impl,
enum mtl_port port) {
struct mt_mcast_impl* mcast = get_mcast(impl, port);
uint16_t group_num = mcast->group_num;
struct rte_mbuf* pkt;
struct rte_ipv4_hdr* ip_hdr;
struct mcast_mb_report_v3* mb_report;
size_t hdr_offset = 0;
size_t mb_report_len = sizeof(struct mcast_mb_report_v3);

mt_pthread_mutex_lock(&mcast->group_mutex);
uint16_t group_num = mcast->group_num;

if (group_num <= 0) {
mt_pthread_mutex_unlock(&mcast->group_mutex);
dbg("%s(%d), no group to join\n", __func__, port);
return 0;
}
Expand All @@ -199,6 +202,7 @@ static int mcast_membership_report_on_query(struct mtl_main_impl* impl,

pkt = rte_pktmbuf_alloc(mt_sys_tx_mempool(impl, port));
if (!pkt) {
mt_pthread_mutex_unlock(&mcast->group_mutex);
err("%s(%d), report packet alloc failed\n", __func__, port);
return -ENOMEM;
}
Expand All @@ -222,6 +226,7 @@ static int mcast_membership_report_on_query(struct mtl_main_impl* impl,
group_record_addr += record_len;
mb_report_len += record_len;
}
mt_pthread_mutex_unlock(&mcast->group_mutex);

uint16_t checksum = mcast_msg_checksum(MEMBERSHIP_REPORT_V3, mb_report, mb_report_len);
if (checksum <= 0) {
Expand Down
Loading