Fix: User pacing test #1319
Draft
Fix: User pacing test #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakoram
force-pushed
the
Add_tests_for_user_timestamp_and_pacing
branch
from
40fdb1a to
97bc3e8
Compare
Signed-off-by: Kasiewicz, Marek <[email protected]>
Collaborator
DawidWesierski4
left a comment
DawidWesierski4
left a comment
There was a problem hiding this comment.
Imo looks good but there is a concern with accuracy of timestamping of st40 with the recent changes
| return st20_tx_get_sch_idx(ctx->transport); | ||
| } | ||
|
|
||
| int st20p_tx_get_pacing_params(st20p_tx_handle handle, double* tr_offset_ns, |
Collaborator
There was a problem hiding this comment.
please add st40 support
thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.