Skip to content

Fix: Addressed out-of-bands read from a buffer in udp_rx_dequeue function #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Addressed out-of-bands read from a buffer in udp_rx_dequeue function #1320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0222502
Addressed the Coverity-reported UDP dequeue issue by tightening the h…
soopel Nov 14, 2025
9507b9d
Apply suggestion from @Copilot
soopel Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions lib/src/udp/udp_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,10 +913,31 @@ static ssize_t udp_rx_dequeue(struct mudp_impl* s, void* buf, size_t len, int fl
s->stat_pkt_dequeue++;

struct mt_udp_hdr* hdr = rte_pktmbuf_mtod(pkt, struct mt_udp_hdr*);
const size_t hdr_len = sizeof(*hdr);
uint32_t pkt_len = rte_pktmbuf_pkt_len(pkt);

if (pkt_len < hdr_len) {
err("%s(%d), invalid packet len %u < header len %zu\n", __func__, idx, pkt_len,
hdr_len);
rte_pktmbuf_free(pkt);
errno = EBADMSG;
return -1;
}

struct rte_udp_hdr* udp = &hdr->udp;
void* payload = &udp[1];
ssize_t payload_len = ntohs(udp->dgram_len) - sizeof(*udp);
dbg("%s(%d), payload_len %" PRIu64 " bytes\n", __func__, idx, payload_len);
ssize_t payload_len = (ssize_t)ntohs(udp->dgram_len) - sizeof(*udp);
ssize_t payload_cap = (ssize_t)pkt_len - hdr_len;

if (payload_len < 0 || payload_len > payload_cap) {
err("%s(%d), invalid payload len %zd (cap %zd)\n", __func__, idx,
payload_len, payload_cap);
rte_pktmbuf_free(pkt);
errno = EBADMSG;
return -1;
}

void* payload = rte_pktmbuf_mtod_offset(pkt, void*, hdr_len);
dbg("%s(%d), payload_len %zd bytes\n", __func__, idx, payload_len);

if (payload_len <= len) {
rte_memcpy(buf, payload, payload_len);
Expand Down
Loading