fix: minimum requirements + add galician skills extras #699
Conversation
WalkthroughThe changes update plugin version constraints in the plugins requirements file, add a new Galician skills requirements file, and register this file as an optional dependency group in the setup configuration. Additionally, a redundant variable initialization is removed from the version retrieval function in the setup script. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SetupScript
participant RequirementsFile
User->>SetupScript: Install with extras 'skills-gl'
SetupScript->>RequirementsFile: Read requirements/skills-gl.txt
RequirementsFile-->>SetupScript: Return list of Galician skills dependencies
SetupScript-->>User: Install ovos-skill-word-of-the-day>=0.2.0
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
setup.py (1)
89-89: Ensure documentation reflects the new extras group.
Theskills-glextras entry is wired correctly. Please update the README or relevant docs to show how to install it (e.g.,pip install ovos-core[skills-gl]).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
requirements/plugins.txt(1 hunks)requirements/skills-gl.txt(1 hunks)setup.py(1 hunks)
🧰 Additional context used
🪛 LanguageTool
requirements/plugins.txt
[locale-violation] ~18-~18: “template” é um estrangeirismo. É preferível dizer “modelo”.
Context: ...0 # intent transformer plugins keyword-template-matcher>=0.1.1,<1.0.0 ahocorasick-ner>=...
(PT_BARBARISMS_REPLACE_TEMPLATE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: unit_tests
🔇 Additional comments (2)
requirements/skills-gl.txt (1)
1-2: Confirm dependency correctness and version constraint.
Verify thatovos-skill-word-of-the-day>=0.2.0is the intended package name and minimum version for Galician skills.requirements/plugins.txt (1)
18-19: Verify plugin version bump compatibility.
Raising the minimum versions forkeyword-template-matcherandahocorasick-nerto>=0.1.1could introduce breaking changes for users on older releases. Confirm that versions 0.1.x maintain backward compatibility and run end-to-end tests on the intent pipeline.🧰 Tools
🪛 LanguageTool
[locale-violation] ~18-~18: “template” é um estrangeirismo. É preferível dizer “modelo”.
Context: ...0 # intent transformer plugins keyword-template-matcher>=0.1.1,<1.0.0 ahocorasick-ner>=...(PT_BARBARISMS_REPLACE_TEMPLATE)
Summary by CodeRabbit
New Features
Chores