Skip to content

improve skill shutdown #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarbasAl merged 2 commits into from
Jun 17, 2025
Merged

improve skill shutdown #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7e364
bump packages
JarbasAl Jun 16, 2025
078d8ca
Update tests.txt
JarbasAl Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ovos_core/skill_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,14 @@ def _unload_plugin_skill(self, skill_id):
LOG.info('Unloading plugin skill: ' + skill_id)
skill_loader = self.plugin_skills[skill_id]
if skill_loader.instance is not None:
try:
skill_loader.instance.shutdown()
except Exception:
LOG.exception('Failed to run skill specific shutdown code: ' + skill_loader.skill_id)
try:
skill_loader.instance.default_shutdown()
except Exception:
LOG.exception('Failed to shutdown plugin skill: ' + skill_loader.skill_id)
LOG.exception('Failed to shutdown skill: ' + skill_loader.skill_id)
self.plugin_skills.pop(skill_id)

def is_alive(self, message=None):
Expand Down
2 changes: 1 addition & 1 deletion requirements/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ ovos-utils[extras]>=0.6.0,<1.0.0
ovos_bus_client>=0.1.4,<2.0.0
ovos-plugin-manager>=1.0.3,<2.0.0
ovos-config>=0.0.13,<3.0.0
ovos-workshop>=7.0.4,<8.0.0
ovos-workshop>=7.0.5,<8.0.0
2 changes: 1 addition & 1 deletion requirements/tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ pytest-cov>=2.8.1
pytest-testmon>=2.1.3
pytest-randomly>=3.16.0
cov-core>=1.15.0
ovoscope>=0.6.0,<1.0.0
ovoscope>=0.7.1,<1.0.0
Loading