Skip to content

fix(setup): set utf-8 encoding when opening files #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarbasAl merged 1 commit into from
Oct 20, 2025
Merged

fix(setup): set utf-8 encoding when opening files #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def get_version():
""" Find the version of ovos-core"""
version_file = os.path.join(BASEDIR, 'ovos_core', 'version.py')
major, minor, build, alpha = (0, 0, 0, 0)
with open(version_file) as f:
with open(version_file, encoding='utf-8') as f:
for line in f:
if 'VERSION_MAJOR' in line:
major = line.split('=')[1].strip()
Expand All @@ -44,7 +44,7 @@ def get_version():

def required(requirements_file):
""" Read requirements file and remove comments and empty lines. """
with open(os.path.join(BASEDIR, requirements_file), 'r') as f:
with open(os.path.join(BASEDIR, requirements_file), 'r', encoding='utf-8') as f:
requirements = f.read().splitlines()
if 'MYCROFT_LOOSE_REQUIREMENTS' in os.environ:
print('USING LOOSE REQUIREMENTS!')
Expand All @@ -53,7 +53,7 @@ def required(requirements_file):
if pkg.strip() and not pkg.startswith("#")]


with open(os.path.join(BASEDIR, "README.md"), "r") as f:
with open(os.path.join(BASEDIR, "README.md"), "r", encoding='utf-8') as f:
long_description = f.read()

PLUGIN_ENTRY_POINT = [
Expand Down
Loading