Complete French boot status locale#68
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR adds and updates French (fr-fr) locale resources for a readiness notification feature, including new dialog files, intent patterns, compiled translation JSON files, and skill metadata. Changes focus on wording improvements and expanded support for readiness-related voice commands and system responses. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locale/fr-fr/intent/enable_ready_notification.intent`:
- Line 1: The intent pattern for enable_ready_notification is missing the elided
singular "l'alerte"; update the pattern segment "(la|les|)" in the intent string
"(activer|allumer|réactiver) (la|les|)
(notification|notifications|alerte|alertes) de (démarrage|redémarrage)" to
include the elision (for example "(l'|la|les|)") so "l'alerte de démarrage"
matches, and make the identical change to the corresponding
enable_ready_notification entry in translations/fr-fr/intents.json; ensure the
apostrophe is properly escaped/handled in whichever format the intent and JSON
use.
In `@locale/fr-fr/skill.json`:
- Around line 6-10: The examples array in locale/fr-fr/skill.json contains
imperative variants "Active" / "Désactive" that don't match the shipped intent
patterns (which only include infinitive forms `activer` / `désactiver` in
enable_ready_notification.intent and translations/fr-fr/intents.json); either
change the two example utterances to use the infinitive forms (e.g., "Activer
les notifications de démarrage." / "Désactiver les notifications de démarrage.")
or add the imperative variants to the enable_ready_notification.intent and
translations/fr-fr/intents.json so the example phrases are covered by the intent
patterns.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a427cf80-4b2c-4df5-bf1a-2fc94e3cb3e8
📒 Files selected for processing (11)
locale/fr-fr/dialog/confirm_no_speak_ready.dialoglocale/fr-fr/dialog/confirm_ready.dialoglocale/fr-fr/dialog/confirm_speak_ready.dialoglocale/fr-fr/dialog/deny_ready.dialoglocale/fr-fr/dialog/ready.dialoglocale/fr-fr/intent/are_you_ready.intentlocale/fr-fr/intent/disable_ready_notification.intentlocale/fr-fr/intent/enable_ready_notification.intentlocale/fr-fr/skill.jsontranslations/fr-fr/dialogs.jsontranslations/fr-fr/intents.json
1 participant
Summary
Validation
Summary by CodeRabbit