Skip to content

Complete French hello world locale#90

Merged
JarbasAl merged 4 commits intodevfrom
feat/fr-fr-locale-complete
Mar 22, 2026
Merged

Complete French hello world locale#90
JarbasAl merged 4 commits intodevfrom
feat/fr-fr-locale-complete

Conversation

@goldyfruit
Copy link
Collaborator

Summary

  • add the missing French greeting intent and hello dialog
  • localize the French skill metadata examples so they match the existing locale

Validation

  • verified fr-fr file coverage against locale/en-us
  • validated ovos_skill_hello_world/locale/fr-fr/skill.json parses as JSON

@coderabbitai
Copy link

coderabbitai bot commented Mar 8, 2026

Warning

Rate limit exceeded

@goldyfruit has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 35f0f425-ab24-4072-97e4-5ab7eaa9b766

📥 Commits

Reviewing files that changed from the base of the PR and between 5654454 and c7ddfd1.

📒 Files selected for processing (9)
  • ovos_skill_hello_world/locale/fr-fr/dialog/hello.dialog
  • ovos_skill_hello_world/locale/fr-fr/intents/Greetings.intent
  • ovos_skill_hello_world/locale/fr-fr/intents/HowAreYou.intent
  • ovos_skill_hello_world/locale/fr-fr/skill.json
  • ovos_skill_hello_world/locale/fr-fr/vocab/HelloWorldKeyword.voc
  • ovos_skill_hello_world/locale/fr-fr/vocab/ThankYouKeyword.voc
  • translations/fr-fr/dialogs.json
  • translations/fr-fr/intents.json
  • translations/fr-fr/vocabs.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/fr-fr-locale-complete
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Coverage report

This PR does not seem to contain any modification to coverable code.

@goldyfruit goldyfruit self-assigned this Mar 9, 2026
@goldyfruit goldyfruit added the translation everything about localisation label Mar 9, 2026
@JarbasAl JarbasAl merged commit ef3428a into dev Mar 22, 2026
4 of 5 checks passed
@JarbasAl JarbasAl deleted the feat/fr-fr-locale-complete branch March 22, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation everything about localisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants