Conversation
Member
Author
|
This is arguably not ideal, and maybe the current ZFS-related code should better be removed from this core component, and provided with a puppet module (e.g. the puppetlabs-zfs_core). That would a be backward-incompatible change though, and maybe not the way we want to go. I am opening this for discussion, but am very interested in the feature in the control repos I manage 😉 Relates to voxpupuli/language-steering#13 |
OpenZFS can be installed on Linux nodes, and is packaged in some Linux distros such as Debian, so it makes sense to make these facts available when the system has support for ZFS.
jessereynolds
approved these changes
Jun 26, 2025
Contributor
jessereynolds
left a comment
jessereynolds
left a comment
There was a problem hiding this comment.
This will be great to have and seems reasonable to include in openfact, it could potentially be split out in the future if it turns out to be a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenZFS can be installed on Linux nodes, and is packaged in some Linux distros such as Debian, so it makes sense to make these facts available when the system has support for ZFS.
This patch was created by copying the FreeBSD code and adjusting the namespaces, and tested successfully on a Debian 12 node.
Originally submitted as:
puppetlabs/facter#2782