Match class & file name for Solaris Filesystems#17
Merged
Conversation
The filename was plural but the class name was inconsistently singular. Other resolvers / facts seems to consistently use plural, so pluralize the class name ta match the file name.
smortex
added
the
backwards-incompatible
jessereynolds
approved these changes
Jun 26, 2025
Contributor
jessereynolds
left a comment
jessereynolds
left a comment
There was a problem hiding this comment.
Consistency FTW. Also, needed for the approach in #16 I believe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filename was plural but the class name was inconsistently singular.
Other resolvers / facts seems to consistently use plural, so pluralize
the class name ta match the file name.