Skip to content

Add a renew subcommand to puppet ssl#363

Open
jay7x wants to merge 2 commits intomainfrom
puppet_ssl_renew
Open

Add a renew subcommand to puppet ssl#363
jay7x wants to merge 2 commits intomainfrom
puppet_ssl_renew

Conversation

@jay7x
Copy link

@jay7x jay7x commented Mar 8, 2026

TODO:

  • Add unit test
  • Test it in reality

@jay7x jay7x marked this pull request as draft March 8, 2026 11:40
@jay7x jay7x force-pushed the puppet_ssl_renew branch from 366cc38 to 6cad913 Compare March 8, 2026 12:35
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. Thoughts:

  • Should it be just puppet ssl renew?
  • Should it look at the expiration date and only renew if it's at X% towards its expiration?
  • If the above is implemented, should it have a --force option to force a renewal?

@jay7x
Copy link
Author

jay7x commented Mar 8, 2026

  • Should it be just puppet ssl renew?

That was my original idea.. But then I decided to follow what we already have (download_cert e.g.). I'm fine to rename back.

  • Should it look at the expiration date and only renew if it's at X% towards its expiration?

Ideally, yes.

  • If the above is implemented, should it have a --force option to force a renewal?

There should be one more option then. It should be possible to say "please renew the certificate if it'll expire in this amount of days". Not sure how to call that.. --if-expiring-in-days? --expiry-days?

I'm not sure if having a "please renew the certificate if it's about X% expired" option is really useful. Usually people think in days.. This option exists in vaultbot IIRC, but I never used it. Any opinions?

@jay7x jay7x marked this pull request as ready for review March 10, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants