-
Notifications
You must be signed in to change notification settings - Fork 2
ERB: Add support for modern Ruby #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall this was introduced in Ruby 2.6 or 2.7 so you'll need to update the lower bound as well:
Line 16 in 85780d0
| gem.required_ruby_version = '>= 2.0.0' |
|
I'm still debating which lower version we need. If I understand the pipelines in openvox-server correctly, the packaging gem is already used on Ruby 3.2. Given that 3.1 and older are already dead, it probably makes sense to directly bump to 3.2? |
|
I think that's fine, but looks like CI also needs to be updated. |
|
Switching to 3.2 in #13 |
Without this, we get: ``` /code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. 2716 /code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. ```
Pull request was closed
Without this, we get: