Skip to content

Conversation

@bastelfreak
Copy link
Contributor

@bastelfreak bastelfreak commented Jul 11, 2025

Without this, we get:

/code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
2716
/code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

@bastelfreak bastelfreak self-assigned this Jul 11, 2025
bastelfreak added a commit to bastelfreak/openvox-server that referenced this pull request Jul 11, 2025
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall this was introduced in Ruby 2.6 or 2.7 so you'll need to update the lower bound as well:

gem.required_ruby_version = '>= 2.0.0'

@bastelfreak
Copy link
Contributor Author

I'm still debating which lower version we need. If I understand the pipelines in openvox-server correctly, the packaging gem is already used on Ruby 3.2. Given that 3.1 and older are already dead, it probably makes sense to directly bump to 3.2?

@ekohl
Copy link
Contributor

ekohl commented Jul 14, 2025

I think that's fine, but looks like CI also needs to be updated.

bastelfreak added a commit to bastelfreak/openvox-server that referenced this pull request Jul 14, 2025
@bastelfreak
Copy link
Contributor Author

Switching to 3.2 in #13

@bastelfreak bastelfreak marked this pull request as ready for review July 14, 2025 16:46
Without this, we get:

```
/code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
2716
/code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
```
@bastelfreak bastelfreak enabled auto-merge July 14, 2025 20:59
auto-merge was automatically disabled July 14, 2025 21:00

Pull request was closed

@bastelfreak bastelfreak reopened this Jul 14, 2025
@bastelfreak bastelfreak added the enhancement New feature or request label Jul 14, 2025
@bastelfreak bastelfreak merged commit 25d5c7e into main Jul 14, 2025
9 checks passed
@bastelfreak bastelfreak deleted the erb branch July 14, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants