change: rename to Line_height

[xiaoxustudio]

重命名pr #763 新增的属性

LineHeight -> Line_height

和其他配置属性统一格式

对应文档 OpenWebGAL/WebGAL_Doc#75

[gemini-code-assist]

Summary of Changes

Hello @xiaoxustudio, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在标准化新引入属性的命名约定。具体来说，它将 LineHeight 重命名为 Line_height，以确保应用程序配置属性之间的一致性，从而提高代码的可读性和可维护性。

Highlights

• 属性重命名: 将 userDataState.globalGameVar 中的 LineHeight 属性重命名为 Line_height，以与其他配置属性的命名格式保持一致。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

你好，感谢你的贡献！本次 PR 主要是将 LineHeight 重命名为 Line_height 以统一命名规范。这个修改是正确的。

此外，我发现了一个相关的潜在问题并提出了修复建议：在获取行高的逻辑中，当前实现会错误地处理 0 这个可能有效的行高值。请查看我的具体评论以了解详情和建议的修改方案。

[gemini-code-assist]

在修改此行的同时，我注意到下一行（193行）可能存在一个潜在问题。当 Line_height 的值为 0 时，textLineHeight ? ... 的判断会为 false，导致回退到默认值 lineHeightValue。然而，0 可能是用户有意设置的有效行高值。为了正确处理这种情况，建议将第193行的判断条件修改为 textLineHeight != null。

建议修改为：

const finalTextLineHeight = textLineHeight != null ? Number(textLineHeight) : lineHeightValue;