feat: improve icon creator

[nini22P]

• 重构图标创建流程提升生成速度。
• 使用 img2ico 替代 img2icojs，提高生成效率。

[gemini-code-assist]

Summary of Changes

Hello @nini22P, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented a significant refactor of the icon creation feature to boost its performance and efficiency. The primary goal was to accelerate the icon generation and saving process, making it a smoother experience for users. This was achieved by upgrading the underlying image processing library and overhauling the entire icon generation and upload workflow. The changes ensure that icons are created and saved faster, with improved visual fidelity.

Highlights

• Performance Improvement and Library Swap: I've refactored the icon creation process to significantly improve generation speed. This involved replacing the custom png2icojs utility with the more efficient img2ico library, streamlining how ICO files are created.
• Refactored Icon Generation Pipeline: The core logic for generating icons has been rewritten. Instead of separate clipping and resizing steps, I've introduced clipToCanvas and resizeCanvasToBlob functions, which are integrated into a new generateAllIcons pipeline. This new approach handles image manipulation more effectively and prepares files for upload.
• Improved Image Quality: I've enhanced the visual quality of the generated icons by enabling imageSmoothingEnabled and setting imageSmoothingQuality to 'high' on all relevant canvas contexts. This ensures that scaled and clipped images appear smoother and more professional.
• Optimized Icon Saving Process: The icon saving mechanism has been optimized. The handleSave function now intelligently groups generated files by their target directories and utilizes Promise.all to upload them concurrently. This parallel processing drastically reduces the time it takes to save all the different icon formats.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request significantly improves the icon creation process by refactoring the generation logic and replacing img2icojs with the more performant img2ico library. The code is now more efficient, generating and uploading icons in parallel. I've provided a few suggestions to further enhance efficiency, robustness, and maintainability.

[gemini-code-assist]

Using non-null assertions (!) for getContext('2d') can make the code less robust. While it's unlikely for getContext to return null on a newly created canvas, it's safer to perform an explicit null check and handle the potential failure gracefully, as was done in the previous implementation. This would prevent potential runtime errors.

This also applies to other getContext('2d')! calls on lines 414, 437, and 460.

    const ctx = croppedIconCanvas.getContext('2d');
    if (!ctx) {
      throw new Error('Failed to get 2D context from croppedIconCanvas');
    }

[gemini-code-assist]

This large, hardcoded fileCreationPromises object can be difficult to maintain. Consider refactoring this configuration into a more structured format, perhaps an array of icon definition objects outside the component.

For the Android icons specifically, their generation is very repetitive across different densities. You could create a helper function or loop over a configuration array to generate these promises programmatically, which would reduce code duplication and make it easier to add or modify densities in the future.