Skip to content

OWC-165 fix for map not working well when you switch back from geodat… #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyalacato wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

OWC-165 fix for map not working well when you switch back from geodat… #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/admin/class-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public static function admin_enqueue_scripts() {
// Only include the script on the kaarten edit pages.
$screen = get_current_screen();

if ( ! in_array( $screen->id, [ 'owc_ok_datalayer' ], true ) ) {
if ( ! in_array( $screen->id, [ 'owc_ok_datalayer', 'owc_ok_location' ], true ) ) {
return;
}

Expand Down
33 changes: 31 additions & 2 deletions src/scripts/openstreetmap-geodata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,36 @@
import L from "leaflet";

// Create the map with the specified configuration.
let map;

// Create the map with the specified configuration on the page load.
window.onload = function() {
// Initialize the map.
initializeMap();
}

// Re-initialize map when switching radio button location_geometry_geodata_type
document.querySelectorAll('input[name="location_geometry_geodata_type"]').forEach(input => {
input.addEventListener( 'change', function () {
// Check if value is 'marker'.
if (this.value === 'marker') {
// Remove existing map if exists
if (map) {
map.remove();
}

// Show your map container
document.getElementById( 'map-geodata' ).style.display = 'block';

// Tell Leaflet to recalculate the map size
setTimeout( function () {
initializeMap();
}, 50 );
}
} );
});


function initializeMap() {
// Check if there is a div with the ID 'map-geodata'.
if ( ! document.getElementById( 'map-geodata' ) ) {
return;
Expand Down Expand Up @@ -29,7 +58,7 @@ window.onload = function() {
"enableBoxZoomControl": true
}

const map = new L.Map('map-geodata', {
map = new L.Map('map-geodata', {
center: [config.centerY, config.centerX],
zoom: config.defaultZoom,
minZoom: config.minimumZoom,
Expand Down