Skip to content

Handle no devices found #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donavanbecker merged 1 commit into from
Nov 18, 2024
Merged

Handle no devices found #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/switchbot-ble.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,11 @@ export class SwitchBotBLE extends EventEmitter {
this.log('error', `discover stopScanningAsync error: ${JSON.stringify(e.message ?? e)}`)
}
}
return Object.values(peripherals)
const devices = Object.values(peripherals)
if (devices.length === 0) {
this.log('warn', 'No devices found during discovery.')
}
return devices
}

return new Promise<SwitchbotDevice[]>((resolve, reject) => {
Expand All @@ -192,7 +196,14 @@ export class SwitchBotBLE extends EventEmitter {

this.noble.startScanningAsync(PRIMARY_SERVICE_UUID_LIST, false)
.then(() => {
timer = setTimeout(async () => resolve(await finishDiscovery()), p.duration)
timer = setTimeout(async () => {
const result = await finishDiscovery()
if (result.length === 0) {
reject(new Error('No devices found during discovery.'))
} else {
resolve(result)
}
}, p.duration)
})
.catch(reject)
})
Expand Down
Loading