Skip to content

Fix: Cannot select a combobox item after scrollbox focus lost #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChugunovRoman wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix: Cannot select a combobox item after scrollbox focus lost #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b80bc
xrUICore/ComboBox/UIComboBox.cpp: fix missing clear mouse capturer if…
ChugunovRoman Dec 18, 2025
f8bcc8a
xrUICore/ComboBox/UIComboBox.cpp: update SetCapture condition
ChugunovRoman Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/xrUICore/ComboBox/UIComboBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,12 @@ void CUIComboBox::ShowList(bool bShow)
}
}

void CUIComboBox::SetCapture(CUIWindow* pChildWindow, bool capture_status)
{
if (m_eState == LIST_EXPANDED && !capture_status)
return;
}

void CUIComboBox::Update()
{
CUIWindow::Update();
Expand Down
2 changes: 2 additions & 0 deletions src/xrUICore/ComboBox/UIComboBox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ class XRUICORE_API CUIComboBox final : public CUIWindow, public CUIOptionsItem,
void disable_id(int id);
void enable_id(int id);

void SetCapture(CUIWindow* pChildWindow, bool capture_status) override;

pcstr GetDebugType() override { return "CUIComboBox"; }

protected:
Expand Down
2 changes: 1 addition & 1 deletion src/xrUICore/Windows/UIWindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class XRUICORE_API CUIWindow : public CUIDebuggable

//захватить/освободить мышь окном
//сообщение посылается дочерним окном родительскому
void SetCapture(CUIWindow* pChildWindow, bool capture_status);
virtual void SetCapture(CUIWindow* pChildWindow, bool capture_status);

[[nodiscard]]
CUIWindow* GetMouseCapturer() const { return m_pMouseCapturer; }
Expand Down
Loading