Mark rsqrt function as noexcept#2041
Merged
Xottab-DUTY merged 1 commit intoOpenXRay:devfrom Feb 1, 2026
Merged
Conversation
Member
|
Is it ever used? I see that it returns double, which aren't used almost always. |
Contributor
Author
You're right it's actually unused. I've updated the PR to instead simply remove the |
Contributor
Author
|
Wait it's not unused. It used right here. No idea how I was able to compile with the |
Member
Successfully compiled on Fedora somehow: https://github.com/OpenXRay/xray-16/actions/runs/21565121323/job/62135268722 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently
clang-21will not compile unless we markrsqrtasnoexcept.Since it just calls
_sqrtwhich is already markednoexceptthis should be fine.