Skip to content

Mark rsqrt function as noexcept#2041

Merged
Xottab-DUTY merged 1 commit intoOpenXRay:devfrom
AMS21:noexcept_rsqrt
Feb 1, 2026
Merged

Mark rsqrt function as noexcept#2041
Xottab-DUTY merged 1 commit intoOpenXRay:devfrom
AMS21:noexcept_rsqrt

Conversation

@AMS21
Copy link
Contributor

@AMS21 AMS21 commented Jan 31, 2026

Apparently clang-21 will not compile unless we mark rsqrt as noexcept.

Since it just calls _sqrt which is already marked noexcept this should be fine.

@Xottab-DUTY
Copy link
Member

Is it ever used? I see that it returns double, which aren't used almost always.

@Xottab-DUTY Xottab-DUTY added the Build issue The issue in the build-time. label Jan 31, 2026
@AMS21
Copy link
Contributor Author

AMS21 commented Feb 1, 2026

Is it ever used? I see that it returns double, which aren't used almost always.

You're right it's actually unused. I've updated the PR to instead simply remove the rsqrt function.

@AMS21 AMS21 changed the title Mark rsqrt function as noexcept Remove rsqrt function Feb 1, 2026
@AMS21
Copy link
Contributor Author

AMS21 commented Feb 1, 2026

Wait it's not unused. It used right here. No idea how I was able to compile with the rsqrt removed :/

@AMS21 AMS21 changed the title Remove rsqrt function Mark rsqrt function as noexcept Feb 1, 2026
@Xottab-DUTY
Copy link
Member

Wait it's not unused. It used right here. No idea how I was able to compile with the rsqrt removed :/

Successfully compiled on Fedora somehow: https://github.com/OpenXRay/xray-16/actions/runs/21565121323/job/62135268722

@Xottab-DUTY Xottab-DUTY merged commit 62b2e33 into OpenXRay:dev Feb 1, 2026
4 of 46 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Feb 1, 2026
@Xottab-DUTY
Copy link
Member

Thanks!

@Xottab-DUTY Xottab-DUTY removed this from Roadmap Feb 1, 2026
@AMS21 AMS21 deleted the noexcept_rsqrt branch February 1, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build issue The issue in the build-time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants