Skip to content

fix(Directory): eliminate X of alias bits on client absent #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kumonda221-CrO3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Directory): eliminate X of alias bits on client absent #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/scala/coupledL2/Directory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,14 @@ class Directory(implicit p: Parameters) extends L2Module {
errorRead := bankTagError

// Meta R/W
val metaWrite = Wire(new MetaEntry)
metaWrite := io.metaWReq.bits.wmeta
metaWrite.alias.foreach(_ := Mux(io.metaWReq.bits.wmeta.clients.orR, io.metaWReq.bits.wmeta.alias.get, 0.U))

metaRead := metaArray.io.r(io.read.fire, io.read.bits.set).resp.data
metaArray.io.w(
metaWen,
io.metaWReq.bits.wmeta,
metaWrite,
io.metaWReq.bits.set,
io.metaWReq.bits.wayOH
)
Expand Down Expand Up @@ -305,6 +309,9 @@ class Directory(implicit p: Parameters) extends L2Module {
io.resp.bits.error := error_s3 // depends on ECC
io.resp.bits.replacerInfo := replacerInfo_s3

// X-state guard of 'alias' field on client absent (For Get, Prefetch...)
io.resp.bits.meta.alias.foreach(_ := Mux(meta_s3.clients.orR, meta_s3.alias.get, 0.U))

dontTouch(io)
dontTouch(metaArray.io)
dontTouch(tagArray.io)
Expand Down