Skip to content

fix(MainPipe): fix l2Error_s3 generation logic #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linjuanZ merged 1 commit into from
Jan 14, 2026
Merged

fix(MainPipe): fix l2Error_s3 generation logic #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/scala/coupledL2/tl2chi/MainPipe.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,7 @@ class MainPipe(implicit p: Parameters) extends TL2CHIL2Module with HasCHIOpcodes

val tagError_s3 = io.dirResp_s3.error || meta_s3.tagErr
val dataError_s3 = meta_s3.dataErr
val l2TagError_s3 = io.dirResp_s3.error
val l2Error_s3 = io.dirResp_s3.error || mshr_req_s3
val l2Error_s3 = io.dirResp_s3.error

val mshr_refill_s3 = mshr_accessackdata_s3 || mshr_hintack_s3 || mshr_grant_s3 // needs refill to L2 DS
val replResp_valid_s3 = io.replResp.valid
Expand Down Expand Up @@ -547,7 +546,7 @@ class MainPipe(implicit p: Parameters) extends TL2CHIL2Module with HasCHIOpcodes
val metaW_s3_a = MetaEntry(
dirty = meta_s3.dirty,
state = Mux(req_needT_s3 || sink_resp_s3_a_promoteT, TRUNK, meta_s3.state),
clients = Fill(clientBits, Mux(l2TagError_s3, false.B, true.B)),
clients = Fill(clientBits, Mux(l2Error_s3, false.B, true.B)),
alias = Some(metaW_s3_a_alias),
accessed = true.B,
tagErr = meta_s3.tagErr,
Expand Down