scons: explicitly define call arg in CheckLibWithHeader

[Yakkhini]

For better compatibility with SCons version 4.9.0 and after.

See also:

• GEM5 upstream repository PR: scons: Explicitly define call arg in CheckLibWithHeader gem5/gem5#2080
• SCons break change: 🐛 Allow passing extra_libs to CheckLibWithHeader SCons/scons#4676

Change-Id: I0082f1b12d6afc25e0791673cd8f7d4c400d8644

Summary by CodeRabbit

• Refactor
  • Updated build configuration API usage by adopting explicit keyword-based parameter passing for library and header validation checks across multiple components, enhancing code consistency without affecting functionality.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR refactors build configuration files across the codebase to use keyword argument syntax (call=...) instead of positional arguments when invoking CheckLibWithHeader and ConfCheck functions. The changes maintain identical behavior while improving API clarity and consistency.

Changes

Cohort / File(s)	Summary
Build Configuration Refactoring SConstruct, src/base/SConsopts, src/base/stats/SConsopts, src/cpu/kvm/SConsopts, src/mem/SConsopts, src/proto/SConsopts, src/sim/SConsopts	Converts positional arguments to keyword argument call= in CheckLibWithHeader/ConfCheck calls. Affected library checks include socket, zlib, zstd, clock\_nanosleep, HDF5, POSIX timers, shared memory, protobuf, and backtrace. No functional behavior changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hopping through configs, we found a cleaner way,
Keyword arguments dancing—much clearer than before!
No logic shifts, just syntax's gentle sway,
Seven files refined, consistency restored with flair. 🌟

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: explicitly converting positional arguments to keyword arguments in CheckLibWithHeader calls across multiple SConsopts files for SCons 4.9.0+ compatibility.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Coremark Smoke Test Results

Branch	IPC	Change
Base (xs-dev)	2.1739	-
This PR	2.1739	➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!