Skip to content

feat(apt): add rsync installation in setup-tools.sh#69

Merged
poemonsense merged 1 commit intomasterfrom
rsync
Dec 6, 2025
Merged

feat(apt): add rsync installation in setup-tools.sh#69
poemonsense merged 1 commit intomasterfrom
rsync

Conversation

@klin02
Copy link
Member

@klin02 klin02 commented Dec 5, 2025

No description provided.

@klin02 klin02 requested a review from poemonsense December 6, 2025 14:37
@poemonsense
Copy link
Member

Did you check https://github.com/OpenXiangShan/difftest/actions/runs/19965376038/job/57255877232

It said:

  cd $NOOP_HOME
  apt-get install rsync
  make verilog BOARD=fpgadiff MILL_ARGS="--difftest-config ESBIDUF" -j2
  make -C difftest fpga-release
  shell: sh -e {0}
  env:
    NOOP_HOME: /__w/difftest/NutShell
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package rsync
Error: Process completed with exit code 100.

@poemonsense
Copy link
Member

Did you check https://github.com/OpenXiangShan/difftest/actions/runs/19965376038/job/57255877232

But it seems CI in xs-env works well. So is rsync correct? Maybe difftest CI fails because of not running apt update. Then we can safely merge this PR

@poemonsense poemonsense merged commit 34515e0 into master Dec 6, 2025
1 check passed
@poemonsense poemonsense deleted the rsync branch December 6, 2025 14:55
@klin02
Copy link
Member Author

klin02 commented Dec 6, 2025

Did you check https://github.com/OpenXiangShan/difftest/actions/runs/19965376038/job/57255877232

But it seems CI in xs-env works well. So is rsync correct? Maybe difftest CI fails because of not running apt update. Then we can safely merge this PR

Yes. Difftest CI fails because of not running apt update. Rsync installs well in xs-env CI, so we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments