test: make all BRS vars immutable

Author: 0xNeshi

tests/block_range_scanner.rs

@@ -16,7 +16,7 @@ async fn live_mode_processes_all_blocks_respecting_block_confirmations() -> anyh
 
     // --- Zero block confirmations -> stream immediately ---
 
-    let mut brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
 
     let mut stream = brs.stream_live(0).await?;
 
@@ -51,7 +51,7 @@ async fn live_mode_processes_all_blocks_respecting_block_confirmations() -> anyh
 async fn live_with_block_confirmations_always_emits_genesis_block() -> anyhow::Result<()> {
     let anvil = Anvil::new().try_spawn()?;
     let provider = ProviderBuilder::new().connect(anvil.ws_endpoint_url().as_str()).await?;
-    let mut brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
 
     let mut stream = brs.stream_live(3).await?;
 
@@ -106,7 +106,7 @@ async fn continuous_blocks_if_reorg_less_than_block_confirmation() -> anyhow::Re
     let anvil = Anvil::new().try_spawn()?;
     let provider = ProviderBuilder::new().connect(anvil.ws_endpoint_url().as_str()).await?;
 
-    let mut brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
 
     let mut stream = brs.stream_live(5).await?;
 
@@ -138,7 +138,7 @@ async fn shallow_block_confirmation_does_not_mitigate_reorg() -> anyhow::Result<
     let anvil = Anvil::new().try_spawn()?;
     let provider = ProviderBuilder::new().connect(anvil.ws_endpoint_url().as_str()).await?;
 
-    let mut brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().connect(provider.clone()).await?;
 
     let mut stream = brs.stream_live(3).await?;
 
@@ -182,8 +182,7 @@ async fn historical_emits_correction_range_when_reorg_below_end() -> anyhow::Res
 
     let end_num = 110;
 
-    let mut brs =
-        BlockRangeScannerBuilder::new().max_block_range(30).connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().max_block_range(30).connect(provider.clone()).await?;
 
     let mut stream = brs
         .stream_historical(BlockNumberOrTag::Number(0), BlockNumberOrTag::Number(end_num))
@@ -214,8 +213,7 @@ async fn historical_emits_correction_range_when_end_num_reorgs() -> anyhow::Resu
 
     provider.anvil_mine(Some(120), None).await?;
 
-    let mut brs =
-        BlockRangeScannerBuilder::new().max_block_range(30).connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().max_block_range(30).connect(provider.clone()).await?;
 
     let mut stream =
         brs.stream_historical(BlockNumberOrTag::Number(0), BlockNumberOrTag::Latest).await?;
@@ -247,8 +245,7 @@ async fn historical_reorg_occurring_immediately_after_finalized_processing_is_ig
 
     provider.anvil_mine(Some(11), None).await?;
 
-    let mut brs =
-        BlockRangeScannerBuilder::new().max_block_range(10).connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().max_block_range(10).connect(provider.clone()).await?;
 
     let mut stream =
         brs.stream_historical(BlockNumberOrTag::Earliest, BlockNumberOrTag::Latest).await?;
@@ -272,8 +269,7 @@ async fn historic_mode_respects_blocks_read_per_epoch() -> anyhow::Result<()> {
 
     provider.anvil_mine(Some(100), None).await?;
 
-    let mut brs =
-        BlockRangeScannerBuilder::new().max_block_range(5).connect(provider.clone()).await?;
+    let brs = BlockRangeScannerBuilder::new().max_block_range(5).connect(provider.clone()).await?;
 
     // ranges where each batch is of max blocks per epoch size
     let mut stream = brs.stream_historical(0, 19).await?;
@@ -300,7 +296,7 @@ async fn historic_mode_respects_blocks_read_per_epoch() -> anyhow::Result<()> {
     assert_closed!(stream);
 
     // range where blocks per epoch is larger than the number of blocks on chain
-    let mut brs = BlockRangeScannerBuilder::new().max_block_range(200).connect(provider).await?;
+    let brs = BlockRangeScannerBuilder::new().max_block_range(200).connect(provider).await?;
 
     let mut stream = brs.stream_historical(0, 20).await?;
     assert_next!(stream, 0..=20);
@@ -321,7 +317,7 @@ async fn historic_mode_normalises_start_and_end_block() -> anyhow::Result<()> {
 
     provider.anvil_mine(Some(11), None).await?;
 
-    let mut brs = BlockRangeScannerBuilder::new().max_block_range(5).connect(provider).await?;
+    let brs = BlockRangeScannerBuilder::new().max_block_range(5).connect(provider).await?;
 
     let mut stream = brs.stream_historical(10, 0).await?;
     assert_next!(stream, 0..=0);