Abstract block looping to seperate crate #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add remained latest tests
ref: use take while
doc: comment about order
0xNeshi
reviewed
Dec 15, 2025
0xNeshi
reviewed
Dec 16, 2025
0xNeshi
reviewed
Dec 16, 2025
0xNeshi
reviewed
Dec 16, 2025
Collaborator
Author
|
Okay should be done re: size_hint Is this what you had in mind |
0xNeshi
reviewed
Dec 18, 2025
Collaborator
0xNeshi
left a comment
0xNeshi
left a comment
There was a problem hiding this comment.
Last change request, we can merge afterwards!
0xNeshi
reviewed
Dec 18, 2025
0xNeshi
previously approved these changes
Dec 18, 2025
0xNeshi
reviewed
Dec 18, 2025
0xNeshi
approved these changes
Dec 18, 2025
Collaborator
Author
|
@0xNeshi Theres a bug we cant merge due to "A conversation must be resolved before this pull request can be merged." |
Collaborator
|
Noticed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have similar block range looping logic across the repo. This makes it so
This PR abstracts away the looping logic so you just need to worry about streaming a batch and handling reorgs to address these issues