Improve logging in event scanner #264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoPatOZ
commented
Dec 16, 2025
| .expect("pending blocks not supported"); | ||
| // Check if in reorg recovery and past the reorg range | ||
| if reorg_ancestor.is_some_and(|a| last_log_block_num <= a) { | ||
| debug!( |
Collaborator
Author
There was a problem hiding this comment.
Im not sure this is useful since is expected internal state ?
LeoPatOZ
commented
Dec 16, 2025
| Ok(ScannerMessage::Notification(Notification::ReorgDetected { | ||
| common_ancestor, | ||
| })) => { | ||
| debug!( |
Collaborator
Author
There was a problem hiding this comment.
LeoPatOZ
commented
Dec 16, 2025
| // since logs haven't been sent yet | ||
| } | ||
| Ok(ScannerMessage::Notification(notification)) => { | ||
| debug!(notification = ?notification, "Received notification"); |
Collaborator
Author
There was a problem hiding this comment.
Notification gets streamed
LeoPatOZ
commented
Dec 16, 2025
| ) -> Result<Vec<Log>, RobustProviderError> { | ||
| let log_filter = log_filter.clone().from_block(*range.start()).to_block(*range.end()); | ||
|
|
||
| match provider.get_logs(&log_filter).await { |
Collaborator
Author
There was a problem hiding this comment.
Removed these are these are both streamed to the consumer so not sure how helpful logs here are
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #52