Skip to content

Conversation

@immrsd
Copy link
Collaborator

@immrsd immrsd commented Aug 20, 2025

No description provided.

@immrsd immrsd requested a review from ericnordelo August 20, 2025 11:34
@immrsd immrsd self-assigned this Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (21d0ce8) to head (dba6d0b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          82       82           
  Lines        2272     2272           
=======================================
  Hits         2099     2099           
  Misses        173      173           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d0ce8...dba6d0b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions to cover ERC4626, but with the latest version this tests won't work. Can you merge the v2 refactor branch and update the tests accordingly?

We can also wait for the v2 refactor PR to get merged first, but please dont forget to update this right after and re-request a review. Thanks!

@immrsd immrsd requested a review from ericnordelo September 8, 2025 11:31
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@immrsd immrsd merged commit 4de6e1d into OpenZeppelin:main Sep 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants