Skip to content

Conversation

@immrsd
Copy link
Collaborator

@immrsd immrsd commented Aug 26, 2025

No description provided.

@immrsd immrsd requested a review from ericnordelo August 26, 2025 12:18
@immrsd immrsd self-assigned this Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (f301f03) to head (7643f77).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
+ Coverage   92.35%   92.38%   +0.02%     
==========================================
  Files          82       82              
  Lines        2264     2272       +8     
==========================================
+ Hits         2091     2099       +8     
  Misses        173      173              
Files with missing lines Coverage Δ
packages/token/src/common/erc2981/erc2981.cairo 96.42% <100.00%> (+0.59%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f301f03...7643f77. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @immrsd. Changes look good.

Since the benchmark workflows only work from PRs opened directly form the repo and not from forks. Let's start creating them directly as a policy. If you don't mind, can you close this PR and reopen it from a local branch so the workflow triggers?

@immrsd immrsd closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants