Skip to content

Use ERC20Bridgeable from Contracts 5.4.0 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 12, 2025

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Aug 8, 2025

Fixes #592

  • For ERC20 cross chain bridging, uses ERC20Bridgeable from Contracts 5.4.0 instead of Community Contracts.
    • Enables upgradeability when cross chain bridging is enabled, since ERC20Bridgeable is included in the upgradeable variants.
    • For custom bridges, uses a state variable instead of immutable, since the bridge address should be set in the initializer for the upgradeable case.
  • Updates the minimum required Contracts version to 5.4.0

Note: This PR does not address other contracts that were removed from Community Contracts. Those should be addressed by #618

@ericglau ericglau requested review from a team as code owners August 8, 2025 20:03
@ericglau ericglau requested a review from ernestognw August 8, 2025 20:03
Copy link

socket-security bot commented Aug 8, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​nomicfoundation/​hardhat-toolbox@​6.0.0 ⏵ 6.1.0981007592 +5100
Updatedhardhat@​2.22.19 ⏵ 2.26.294 +110090 +110080
Added@​openzeppelin/​hardhat-upgrades@​3.9.19910010089100
Added@​openzeppelin/​contracts-upgradeable@​5.4.010010010094100
Updated@​openzeppelin/​contracts@​5.3.0 ⏵ 5.4.0100100 +510094100

View full report

Copy link

socket-security bot commented Aug 8, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@ernestognw
Copy link
Member

ernestognw commented Aug 11, 2025

I'm not entirely sure how to fix the MCP error. It's failing because the wizard version installed in packages/mcp doesn't have the upgradeable ERC20Bridgeable version. Does that require a release?

@ericglau
Copy link
Member Author

Updated MCP testcase to not expect an error when using ERC20Bridgeable with upgradeable.

@ericglau ericglau merged commit f39adfd into OpenZeppelin:master Aug 12, 2025
17 checks passed
@ericglau ericglau deleted the contracts540 branch August 12, 2025 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ERC20Bridgeable to use OpenZeppelin Contracts v5.4.0
3 participants