-
Notifications
You must be signed in to change notification settings - Fork 186
[Cairo] Add ERC1155Supply to 4.0.0-alpha.0 #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericnordelo
wants to merge
3
commits into
cairo/4.0.0-alpha.0
Choose a base branch
from
cairo/add-ERC1155Supply
base: cairo/4.0.0-alpha.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@openzeppelin/wizard-common": patch | ||
| --- | ||
|
|
||
| Cairo: ERC1155 supply tracking description for AI prompts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says 3.1.0 but
packages/core/cairo_alpha/package.jsonsays 4.0.0-alpha.0 (the same occurs in the other PRs)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I updated because I remembered you mentioned at some point that wizard releases and the version of the contracts library were not pegged, and also the rest of this file follow the format of not using alphas. We still need alpha in the package.json version because that is used in the alpha switch in the UI, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the versions don't need to be pegged, but using Contracts for Cairo v4 is a breaking change.
We can just leave this line as
More detailed explanation (we should document this process):
The alpha switch label uses
contractsVersionTagfrompackages/core/cairo_alpha/src/utils/version.ts.All packages use changesets, except for cairo_alpha (which is excluded from the NPM release process, so we manually keep track of changes in its CHANGELOG.md. Those entries need to be manually moved into a changeset when we eventually promote it from alpha to stable for release).
When we merge/promote alpha to stable, we'll need to do the following in the resulting PR:
## Unreleasedsection to a changeset (new .md file under.changeset), targeting a major version bump of@openzeppelin/wizard-cairopackages/core/cairo/package.jsonis NOT bumped manually (e.g. it must remain 3.x when we want to release 4.0.0)packages/core/cairo/CHANGELOG.md, and update the version inpackages/core/cairo/package.json