Conversation
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ericnordelo
commented
Sep 19, 2025
Contributor
There was a problem hiding this comment.
@ericnordelo FYI the reason the build was failing was due to using .ts file references in the markdown which was causing some weird behaviors, likely due to some kind of race condition of compiling the ts and the markdown. Updating it to JS fixed it, hope that's ok!
stevedylandev
approved these changes
Sep 22, 2025
Contributor
|
Everything looks great to me! Especially love some of the API components you put together, I might try to implement that into the solidity docgen templates. If everything looks good to you too then either you or I can merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-going effort to make the contracts-cairo docs ready for release.