Skip to content

Conversation

@Amxx
Copy link
Contributor

@Amxx Amxx commented Feb 18, 2025

Fixes #58

@Amxx Amxx requested review from ernestognw and frangio February 18, 2025 08:50
@Amxx
Copy link
Contributor Author

Amxx commented Feb 18, 2025

Ideally, I would merge #57 first (into master, and then cherrypicked here)

@frangio
Copy link
Contributor

frangio commented Feb 18, 2025

#57 is merged now.

@Amxx
Copy link
Contributor Author

Amxx commented Feb 18, 2025

Actually, we don't need to cherrypick. We can just merge this, and tag/publish the resulting comming on master

@frangio
Copy link
Contributor

frangio commented Feb 18, 2025

That's a little confusing. I'd suggest rebasing this PR on master.

@Amxx Amxx merged commit 87caafd into master Feb 19, 2025
2 checks passed
@Amxx Amxx deleted the v1.0.8 branch February 19, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider publishing a new version

2 participants