Skip to content

Conversation

@Marcofann
Copy link
Contributor

  1. Bug Fix in returns2 helper:

    • Fixed a TypeError by correcting the property access for VariableDeclaration nodes.
    • Before: item.typeDescriptions.typeString (incorrect)
    • After: item.typeName.typeDescriptions.typeString (correct)
  2. Improved Error Message in inheritance helper:

    • Clarified the error message to be more descriptive and accurate.
    • Before: used inherited-items on non-contract
    • After: inheritance modifier used on non-contract
  3. Code Refactoring in functions helper:

    • Removed a redundant array spread [...[...findAll()]]. findAll() already returns an iterable that can be filtered directly.

PR Checklist

  • Tests (No new tests needed as this fixes existing template logic)
  • Documentation (Changes are internal to the doc generator)
  • Changeset entry (run npx changeset add)

@Marcofann Marcofann requested a review from a team as a code owner August 5, 2025 18:29
@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: 2f6e291

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestognw ernestognw changed the title fix(docs): Correct bugs and improve template helper properties.js Improve docs template helper properties.js Aug 5, 2025
@ernestognw ernestognw merged commit 99eda22 into OpenZeppelin:master Aug 9, 2025
23 of 24 checks passed
@arr00
Copy link
Contributor

arr00 commented Dec 11, 2025

@Marcofann @ernestognw this broke local docs generation for me. Reverting the changes on line 68,69 fixes it. Running node v20.19.5.

Error:

findAll.filter is not a function or its return value is not iterable

#6221

@ernestognw ernestognw mentioned this pull request Jan 12, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants