Skip to content

Fix invalid length check in SignatureChecker #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2025
+1 −1
Merged

Fix invalid length check in SignatureChecker #5973

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c50704e
Fix invalid length check in SignatureChecker
Amxx Oct 6, 2025
40051ec
Revert _extractSignatureValidator and add note
ernestognw Oct 6, 2025
2f645b3
Revert "Fix invalid length check in SignatureChecker"
ernestognw Oct 6, 2025
e61b136
Revert "Revert "Fix invalid length check in SignatureChecker""
ernestognw Oct 6, 2025
d78ff40
Revert "Revert _extractSignatureValidator and add note"
ernestognw Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/utils/cryptography/SignatureChecker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ library SignatureChecker {
mcopy(add(ptr, 0x44), signature, add(length, 0x20))

let success := staticcall(gas(), signer, ptr, add(length, 0x64), 0x00, 0x20)
result := and(success, and(gt(returndatasize(), 0x19), eq(mload(0x00), selector)))
result := and(success, and(gt(returndatasize(), 0x1f), eq(mload(0x00), selector)))
}
}

Expand Down