Skip to content

Dealocate unused memory when queuing transactions #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −0
Open

Dealocate unused memory when queuing transactions #6115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aed511
Dealocate unused memory when queuing transactions
Amxx Nov 14, 2025
0333638
Apply suggestions from code review
Amxx Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contracts/governance/extensions/GovernorTimelockCompound.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ pragma solidity ^0.8.24;
import {IGovernor, Governor} from "../Governor.sol";
import {ICompoundTimelock} from "../../vendor/compound/ICompoundTimelock.sol";
import {Address} from "../../utils/Address.sol";
import {Memory} from "../../utils/Memory.sol";
import {SafeCast} from "../../utils/math/SafeCast.sol";

/**
Expand Down Expand Up @@ -70,12 +71,14 @@ abstract contract GovernorTimelockCompound is Governor {
) internal virtual override returns (uint48) {
uint48 etaSeconds = SafeCast.toUint48(block.timestamp + _timelock.delay());

Memory.Pointer ptr = Memory.getFreeMemoryPointer();
for (uint256 i = 0; i < targets.length; ++i) {
if (
_timelock.queuedTransactions(keccak256(abi.encode(targets[i], values[i], "", calldatas[i], etaSeconds)))
) {
revert GovernorAlreadyQueuedProposal(proposalId);
}
Memory.setFreeMemoryPointer(ptr); // deallocate the memory that was reserved by "abi.encode".
_timelock.queueTransaction(targets[i], values[i], "", calldatas[i], etaSeconds);
}

Expand Down
Loading