Skip to content

Remove unused IERC165 imports from AccessControl extensions #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azzurra88 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused IERC165 imports from AccessControl extensions #6256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions contracts/access/extensions/AccessControlDefaultAdminRules.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {AccessControl, IAccessControl} from "../AccessControl.sol";
import {SafeCast} from "../../utils/math/SafeCast.sol";
import {Math} from "../../utils/math/Math.sol";
import {IERC5313} from "../../interfaces/IERC5313.sol";
import {IERC165} from "../../utils/introspection/IERC165.sol";

/**
* @dev Extension of {AccessControl} that allows specifying special rules to manage
Expand Down Expand Up @@ -61,7 +60,7 @@ abstract contract AccessControlDefaultAdminRules is IAccessControlDefaultAdminRu
_grantRole(DEFAULT_ADMIN_ROLE, initialDefaultAdmin);
}

/// @inheritdoc IERC165
/// @inheritdoc AccessControl
function supportsInterface(bytes4 interfaceId) public view virtual override returns (bool) {
return interfaceId == type(IAccessControlDefaultAdminRules).interfaceId || super.supportsInterface(interfaceId);
}
Expand Down
3 changes: 1 addition & 2 deletions contracts/access/extensions/AccessControlEnumerable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ pragma solidity ^0.8.24;
import {IAccessControlEnumerable} from "./IAccessControlEnumerable.sol";
import {AccessControl} from "../AccessControl.sol";
import {EnumerableSet} from "../../utils/structs/EnumerableSet.sol";
import {IERC165} from "../../utils/introspection/ERC165.sol";

/**
* @dev Extension of {AccessControl} that allows enumerating the members of each role.
Expand All @@ -16,7 +15,7 @@ abstract contract AccessControlEnumerable is IAccessControlEnumerable, AccessCon

mapping(bytes32 role => EnumerableSet.AddressSet) private _roleMembers;

/// @inheritdoc IERC165
/// @inheritdoc AccessControl
function supportsInterface(bytes4 interfaceId) public view virtual override returns (bool) {
return interfaceId == type(IAccessControlEnumerable).interfaceId || super.supportsInterface(interfaceId);
}
Expand Down
Loading