Skip to content

perf: short-circuit Slice equality on length mismatch #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VolodymyrBg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: short-circuit Slice equality on length mismatch #6338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contracts/utils/Memory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,11 @@ library Memory {

/// @dev Returns true if the two slices contain the same data.
function equal(Slice a, Slice b) internal pure returns (bool result) {
Memory.Pointer ptrA = _pointer(a);
Memory.Pointer ptrB = _pointer(b);
uint256 lenA = length(a);
uint256 lenB = length(b);
if (lenA != lenB) return false;
Memory.Pointer ptrA = _pointer(a);
Memory.Pointer ptrB = _pointer(b);
assembly ("memory-safe") {
result := eq(keccak256(ptrA, lenA), keccak256(ptrB, lenB))
}
Expand Down
Loading