Skip to content

Comments

Updated README.md#9

Merged
KitHat merged 5 commits intomainfrom
readme-update
Dec 24, 2025
Merged

Updated README.md#9
KitHat merged 5 commits intomainfrom
readme-update

Conversation

@KitHat
Copy link
Member

@KitHat KitHat commented Dec 22, 2025

Also added proper version for the package

Summary by CodeRabbit

  • Documentation

    • Added comprehensive Deployment section with detailed architecture overview, constructor dependencies, parameterization details including default values, two-step deployment process guide, and deployment instructions with examples for local and live networks.
  • Chores

    • Updated package version.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR adds comprehensive deployment documentation to README.md, describing the InputSettlerXCMEscrow architecture, constructor dependencies, deployment module structure, two-step deployment process, and concrete deployment instructions for local and live networks. It also updates the package version from 1.0.0 to 0.1.0.

Changes

Cohort / File(s) Summary
Documentation
README.md
Adds Deployment section documenting InputSettlerXCMEscrow architecture, constructor dependencies (inkLibrary, xcmPrecompile, baseSettler), two-step deployment process, parameterization details, and deployment instructions for local nodes and live networks with command examples
Package Metadata
package.json
Updates version field from "1.0.0" to "0.1.0"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

These are straightforward changes consisting of documentation additions and a single metadata field update with no logic, code, or structural modifications.

Poem

🐰 The doc now blooms with deployment care,
Instructions clear, from here to there,
A version shift, so light and fair,
The settler escrow takes the air! 🚀✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Updated README.md' is vague and generic, failing to convey the specific content additions (deployment documentation and version changes). Consider a more descriptive title such as 'Add deployment documentation and update version to README and package.json' to better reflect the actual changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52f503f and 8200377.

📒 Files selected for processing (2)
  • README.md
  • package.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

81-81: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test
🔇 Additional comments (5)
package.json (1)

3-3: Version downgrade looks intentional.

The version was reverted from 1.0.0 to 0.1.0. Assuming this aligns with your release strategy and the documentation changes introduced in this PR, this change looks good.

README.md (4)

64-73: Well-documented contract architecture.

The explanation of the three constructor dependencies (inkLibrary, xcmPrecompile, baseSettler) and the two-step deployment process is clear and concise. Good breakdown of what each dependency does.


83-94: Clear local node deployment instructions.

The deployment command example is concrete and well-documented, including the note about the default inkLibrary address causing reverts if not overridden. This helps users avoid common pitfalls.


96-101: Live network deployment guidance is solid.

The instructions for deploying to live networks follow the same pattern as local deployment, with clear guidance on parameterization. The formatting and examples are easy to follow.


81-81: Verify the external repository reference is still maintained.

The xcm-in-smart-contracts-workshop repository link could not be verified as currently public or accessible. Consider updating this reference to point to official, maintained resources such as ink! 5.1 documentation for XCM usage: https://use.ink/basics/xcm, or the pallet-contracts-xcm repository that allows sending and receiving XCM messages, which provide current deployment practices for XCM in smart contracts.

Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bidzyyys bidzyyys marked this pull request as draft December 23, 2025 11:35
@bidzyyys bidzyyys self-requested a review December 23, 2025 11:36
Copy link
Collaborator

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KitHat KitHat marked this pull request as ready for review December 23, 2025 15:31
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KitHat KitHat merged commit 21b6422 into main Dec 24, 2025
3 checks passed
@bidzyyys bidzyyys deleted the readme-update branch December 29, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants