docs: clarify Defender Deploy Environment API keys#1155
Merged
CoveMB merged 3 commits intoOpenZeppelin:masterfrom May 9, 2025
Merged
docs: clarify Defender Deploy Environment API keys#1155CoveMB merged 3 commits intoOpenZeppelin:masterfrom
CoveMB merged 3 commits intoOpenZeppelin:masterfrom
Conversation
robaribas
force-pushed
the
docs/clarify-defender-api-keys
branch
from
08b14aa to
97ca38f
Compare
Contributor
Author
ericglau
requested changes
May 8, 2025
ericglau
approved these changes
May 8, 2025
CoveMB
reviewed
May 9, 2025
Co-authored-by: Cove Marquis-Bortoli <44323490+CoveMB@users.noreply.github.com>
Contributor
Author
|
@CoveMB committed your suggestions. I think its good to go now. |
Contributor
Author
|
The CI test passed. 🚀 btw, Thanks for taking time to review this. ❤️ |
Member
|
the PRs can be merged independently, thanks |
CoveMB
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue described in #996 by clarifying that the API keys referenced in the Defender integration documentation are specifically from the Production or Test Deploy Environment that was configured in Defender.
Changes made:
defender-deploy.adocto add a note explaining that the API keys are specifically from the Deploy Environmentfoundry-defender.adocto clarify that the API keys are from the Deploy EnvironmentFixes
Closes #996
Checklist