test: standardize test function names across codebase

contracts/src/access/control/mod.rs

@@ -449,7 +449,7 @@ mod tests {
     unsafe impl TopLevelStorage for AccessControl {}
 
     #[motsu::test]
-    fn default_role_is_default_admin(
+    fn get_role_admin_returns_default_admin_for_standard_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -458,7 +458,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn default_admin_roles_admin_is_itself(
+    fn get_role_admin_returns_default_admin_for_default_admin_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -468,7 +468,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn non_admin_cannot_grant_role_to_others(
+    fn grant_role_reverts_when_not_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -479,7 +479,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn accounts_can_be_granted_roles_multiple_times(
+    fn grant_role_succeeds_assigning_role_multiple_times(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -493,7 +493,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn not_granted_roles_can_be_revoked(
+    fn revoke_role_succeeds_removing_ungranted_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -508,7 +508,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn admin_can_revoke_role(
+    fn revoke_role_succeeds_removing_granted_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -524,7 +524,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn non_admin_cannot_revoke_role(
+    fn revoke_role_reverts_when_not_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -539,7 +539,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn roles_can_be_revoked_multiple_times(
+    fn revoke_role_succeeds_removing_role_multiple_times(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -553,7 +553,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn bearer_can_renounce_role(
+    fn renounce_role_succeeds_removing_own_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -567,7 +567,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn only_sender_can_renounce(
+    fn renounce_role_reverts_when_not_sender(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -579,7 +579,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn roles_can_be_renounced_multiple_times(
+    fn renounce_role_succeeds_removing_role_multiple_times(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -593,7 +593,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn a_roles_admin_role_can_change(
+    fn _set_role_admin_succeeds_updating_admin_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -605,7 +605,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn the_new_admin_can_grant_roles(
+    fn grant_role_succeeds_assigning_role_with_new_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -619,7 +619,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn the_new_admin_can_revoke_roles(
+    fn revoke_role_succeeds_removing_role_with_new_admins(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -634,7 +634,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn previous_admins_no_longer_grant_roles(
+    fn grant_role_reverts_when_called_by_old_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -648,7 +648,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn previous_admins_no_longer_revoke_roles(
+    fn revoke_role_reverts_when_called_by_old_admin(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -662,7 +662,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn does_not_revert_if_sender_has_role(
+    fn _check_role_succeeds_verifying_granted_role(
         contract: Contract<AccessControl>,
         alice: Address,
     ) {
@@ -687,7 +687,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_grant_role_true_if_no_role(
+    fn _grant_role_true_if_no_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -697,7 +697,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_grant_role_false_if_role(
+    fn _grant_role_succeeds_with_existing_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -709,7 +709,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_revoke_role_true_if_role(
+    fn _revoke_role_succeeds_removing_existing_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,
@@ -722,7 +722,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn internal_revoke_role_false_if_no_role(
+    fn _revoke_role_succeeds_with_nonexistent_role(
         contract: Contract<AccessControl>,
         alice: Address,
         bob: Address,

contracts/src/access/ownable.rs

@@ -294,7 +294,6 @@ mod tests {
     #[motsu::test]
     fn constructor(contract: Contract<Ownable>, alice: Address) {
         contract.sender(alice).constructor(alice).unwrap();
-
         let owner = contract.sender(alice).owner();
         assert_eq!(owner, alice);
 
@@ -319,7 +318,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn transfers_ownership(
+    fn transfer_ownership_updates_owner_address(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,
@@ -340,7 +339,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_transferring(
+    fn transfer_ownership_reverts_when_not_owner(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,
@@ -352,7 +351,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_reaching_stuck_state(
+    fn transfer_ownership_reverts_when_transferring_to_zero_address(
         contract: Contract<Ownable>,
         alice: Address,
     ) {
@@ -367,7 +366,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn loses_ownership_after_renouncing(
+    fn renounce_ownership_sets_zero_address(
         contract: Contract<Ownable>,
         alice: Address,
     ) {
@@ -387,7 +386,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_renouncing(
+    fn renounce_ownership_reverts_when_not_owner(
         contract: Contract<Ownable>,
         alice: Address,
         bob: Address,
@@ -398,19 +397,6 @@ mod tests {
         assert!(matches!(err, Error::UnauthorizedAccount(_)));
     }
 
-    #[motsu::test]
-    fn recovers_access_using_internal_transfer(
-        contract: Contract<Ownable>,
-        alice: Address,
-        bob: Address,
-    ) {
-        contract.sender(alice).constructor(bob).unwrap();
-
-        contract.sender(alice)._transfer_ownership(bob);
-        let owner = contract.sender(alice).owner();
-        assert_eq!(owner, bob);
-    }
-
     #[motsu::test]
     fn interface_id() {
         let actual = <Ownable as IOwnable>::interface_id();

contracts/src/access/ownable_two_step.rs

@@ -251,7 +251,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn reads_pending_owner(
+    fn pending_owner_returns_current_address(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -263,7 +263,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn initiates_ownership_transfer(
+    fn transfer_ownership_succeeds_updating_pending_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -276,10 +276,11 @@ mod tests {
             .expect("should initiate ownership transfer");
 
         assert_eq!(contract.sender(alice).owner(), alice);
+        assert_eq!(contract.sender(alice).pending_owner(), bob);
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_initiating_transfer(
+    fn transfer_ownership_reverts_when_not_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -297,7 +298,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn accepts_ownership(
+    fn accept_ownership_succeeds_completing_transfer(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -314,7 +315,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_pending_owner_from_accepting(
+    fn accept_ownership_reverts_when_not_pending_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -333,7 +334,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn completes_two_step_ownership_transfer(
+    fn transfer_ownership_succeeds_with_complete_flow(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -356,9 +357,11 @@ mod tests {
     }
 
     #[motsu::test]
-    fn renounces_ownership(contract: Contract<Ownable2Step>, alice: Address) {
+    fn renounce_ownership_succeeds_clearing_owner(
+        contract: Contract<Ownable2Step>,
+        alice: Address,
+    ) {
         contract.sender(alice).constructor(alice).unwrap();
-
         contract
             .sender(alice)
             .renounce_ownership()
@@ -367,7 +370,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn prevents_non_owners_from_renouncing(
+    fn renounce_ownership_reverts_when_not_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -384,7 +387,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn cancels_transfer_on_renounce(
+    fn renounce_ownership_succeeds_clearing_pending_transfer(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -401,7 +404,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn allows_owner_to_cancel_transfer(
+    fn transfer_ownership_succeeds_canceling_transfer(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,
@@ -418,7 +421,7 @@ mod tests {
     }
 
     #[motsu::test]
-    fn allows_owner_to_overwrite_transfer(
+    fn transfer_ownership_succeeds_overwriting_pending_owner(
         contract: Contract<Ownable2Step>,
         alice: Address,
         bob: Address,