Skip to content

fix: remove isInternalAgent flag due to hook ordering race condition #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tarquinen merged 1 commit into from
Jan 6, 2026
Merged

fix: remove isInternalAgent flag due to hook ordering race condition #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,10 @@ const plugin: Plugin = (async (ctx) => {
"Summarize what was done in this conversation",
]
if (internalAgentSignatures.some((sig) => systemText.includes(sig))) {
logger.info("Skipping DCP injection for internal agent")
state.isInternalAgent = true
logger.info("Skipping DCP system prompt injection for internal agent")
return
}

// Reset flag for normal sessions
state.isInternalAgent = false

const discardEnabled = config.tools.discard.enabled
const extractEnabled = config.tools.extract.enabled

Expand Down
2 changes: 1 addition & 1 deletion lib/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function createChatMessageTransformHandler(
return async (input: {}, output: { messages: WithParts[] }) => {
await checkSession(client, state, logger, output.messages)

if (state.isSubAgent || state.isInternalAgent) {
if (state.isSubAgent) {
return
}

Expand Down
2 changes: 0 additions & 2 deletions lib/state/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export function createSessionState(): SessionState {
return {
sessionId: null,
isSubAgent: false,
isInternalAgent: false,
prune: {
toolIds: [],
},
Expand All @@ -63,7 +62,6 @@ export function createSessionState(): SessionState {
export function resetSessionState(state: SessionState): void {
state.sessionId = null
state.isSubAgent = false
state.isInternalAgent = false
state.prune = {
toolIds: [],
}
Expand Down
1 change: 0 additions & 1 deletion lib/state/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export interface Prune {
export interface SessionState {
sessionId: string | null
isSubAgent: boolean
isInternalAgent: boolean
prune: Prune
stats: SessionStats
toolParameters: Map<string, ToolParameterEntry>
Expand Down