fix: deduplicator param access and batch tool exclusion #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters Session message ToolPart stores input in part.state.input, not part.parameters. When parameters were undefined, all tools of the same type got identical signatures, causing the deduplicator to incorrectly mark them all as duplicates.
Tarquinen
deleted the
fix/deduplicator-param-access-and-batch-exclusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
part.state.inputinstead ofpart.parameters. Session message ToolPart stores input inpart.state.input, notpart.parameters. When parameters were undefined, all tools of the same type got identical signatures, causing the deduplicator to incorrectly mark them all as duplicates.extractParameterKeyto display-utils module for better code organization.Version
v0.3.18