refactor: introduce adapter pattern for nudge injection #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e formats Consolidate duplicate code for OpenAI Chat, Gemini, and Responses API formats by introducing a MessageFormatAdapter interface. This creates a single generic injectNudgeCore function that works with any adapter, reducing code duplication and improving maintainability. - Create MessageFormatAdapter interface with countToolResults and appendNudge - Implement openaiAdapter, geminiAdapter, and responsesAdapter - Condense verbose multi-line conditionals into compact single-line form - Remove redundant comments while preserving functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MessageFormatAdapterinterface