You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat(shared-data): New NEST Labware and Inner Well Geometries added to millipore labware (#18807)
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:
https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests
GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->
# Overview
Added the nest 12 22ml, nest 8 22ml, and nest 24 ml labware definitions
+ inner geometry labware def. Added axygen 96, ibidi 384, and smc 384
inner geometry labware defs.
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->
## Test Plan and Hands on Testing
Validated the labware definitions using the manufacturer drawings +
calipers. Tested labware definition with lld-test-liquid-height-3mm
protocol, verified volumes to be within the acceptable 3mm from bottom
and 3mm from top ranges.
Validated the inner labware definitions using the same protocol,
calculating the height using the robot api. Verified volumes to be
within the acceptable ranges for top and bottom.
<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->
## Changelog
<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->
## Review requests
<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->
## Risk assessment
<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
---------
Co-authored-by: ABR <[email protected]>
Co-authored-by: Rhyann Clarke <[email protected]>
0 commit comments